Clarify that backport PR needs to include GH- from master#392
Merged
Conversation
Mariatta
added a commit
to python/bedevere
that referenced
this pull request
Jun 24, 2018
If a PR is made not against master, check the PR title. If the PR title does not match the backport pattern, post a failure status. Two ways to resolve: - reopen the PR against master - Update the PR title accordingly Depends on python/devguide#392 Closes python/core-workflow#211 Closes #111
1 task
Mariatta
force-pushed
the
clarify-backport-pr-title
branch
from
bedd994 to
6236a1e
Compare
Member
Author
|
Thanks! |
Mariatta
added a commit
to python/bedevere
that referenced
this pull request
Jul 21, 2018
If a PR is made not against master, check the PR title. If the PR title does not match the backport pattern, post a failure status. Two ways to resolve: - reopen the PR against master - Update the PR title accordingly Depends on python/devguide#392 Closes python/core-workflow#211 Closes #111
Mariatta
added a commit
to python/bedevere
that referenced
this pull request
Jul 21, 2018
* Post a status check for backport PR title. If a PR is made not against master, check the PR title. If the PR title does not match the backport pattern, post a failure status. Two ways to resolve: - reopen the PR against master - Update the PR title accordingly Depends on python/devguide#392 Closes python/core-workflow#211 Closes #111
AA-Turner
pushed a commit
to AA-Turner/devguide
that referenced
this pull request
Jun 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport PR needs to be in the form of
[X.Y] title (GH-NNNN), this is the pattern that bedevere uses:https://github.com/python/bedevere/blob/master/bedevere/backport.py#L11
Adding a bookmark link, so I can reference it from a new status check proposed in python/core-workflow#211 (comment)